Taskflow workstream review #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
commented
Jun 11, 2024
| @@ -661,7 +661,140 @@ namespace WorkStream | |||
|
|
|||
| } // namespace tbb_no_coloring | |||
| # endif // DEAL_II_WITH_TBB | |||
| # ifdef DEAL_II_WITH_TASKFLOW | |||
include/deal.II/base/work_stream.h
Outdated
| typename Iterator, | ||
| typename ScratchData, | ||
| typename CopyData> | ||
| void run(const Iterator & begin, |
There was a problem hiding this comment.
can you add a comment to the run function as
/**
*
*/
that mentions that you are ignoring the last 2 arguments?
include/deal.II/base/work_stream.h
Outdated
|
|
||
| unsigned int idx = 0; | ||
|
|
||
| std::vector<std::unique_ptr<CopyData>> copy_datas; |
There was a problem hiding this comment.
add a comment that this is used to communicate between worked and copier?
include/deal.II/base/work_stream.h
Outdated
|
|
||
| // Find our currently used scratch data and | ||
| // mark it as unused. | ||
| for (typename ScratchDataList::iterator p = |
There was a problem hiding this comment.
I think this could be a ranged-for:
Suggested change
| for (typename ScratchDataList::iterator p = | |
| for (auto &p : scratch_data_list) |
RyanMoulday
force-pushed
the
Taskflow-Workstream
branch
5 times, most recently
from
d05c8e0 to
ecc709c
Compare
RyanMoulday
force-pushed
the
Taskflow-Workstream
branch
from
ecc709c to
79d0fc7
Compare
step-87: Clear ghost values in a vector
Add DiscreteTime::serialize() and DiscreteTime::memory_consumption()
testing of step-40 to step-49
testing step-70 to step-79
Fix Tpetra types for older Trilinos
CMake: Explain why we disable dynamic linking on Windows.
step-29 no longer uses deallog. Update output in results.dox accordingly.
Updates to the LogStream documentation.
Remove an unnecessary 'typename' in step-19.
Make a 'Mapping' object 'const'.
Support codim-1 in hyper_shell() and hyper_cube_with_cylindrical_hole()
testing of step-80 to step-89
…_index_nodal_simplex Add `face_to_cell_index_nodal` for simplex elements
.gitattributes: update for testsuite changes
MGTwoLevelTransfer: Use function without constraints forgotten before
Update changes file for release
Adjust tests for class Lazy.
Fix MSVC not finding an overloaded function.
Update VERSION
FEFaceEvaluation: Implement normal hessian
Windows: Use GNU patch instead of Strawberry Perl patch.
Post release branch: Require the current version of deal.II
Post release branch: switch DEAL_II_DEPRECATED_EARLY to DEAL_II_DEPRECATED
Fix some more dependencies.
Obey the rule of 5 or 7 in TaskResult.
RyanMoulday
force-pushed
the
Taskflow-Workstream
branch
from
e7144c0 to
e14716c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.