Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10801: IS_CI should be checking !isTTY #144

Merged
merged 3 commits into from
Mar 27, 2024
Merged

TINY-10801: IS_CI should be checking !isTTY #144

merged 3 commits into from
Mar 27, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Mar 26, 2024 •
edited
Loading

Related Ticket: TINY-10801

Description of Changes:
IS_CI is now checking for not TTY.

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@danoaky-tiny danoaky-tiny requested a review from a team as a code owner March 26, 2024 00:42
@danoaky-tiny danoaky-tiny changed the title TINY-10801: IS_CI should be checking not isTTY TINY-10801: IS_CI should be checking !isTTY Mar 26, 2024
@danoaky-tiny danoaky-tiny merged commit df38274 into master Mar 27, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/TINY-10801 branch March 27, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltrouton ltrouton ltrouton approved these changes

@TheSpyder TheSpyder TheSpyder approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@vpyshnenko vpyshnenko Awaiting requested review from vpyshnenko vpyshnenko is a code owner automatically assigned from tinymce/tinymce-reviewers

@ArvinJ-H ArvinJ-H Awaiting requested review from ArvinJ-H

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danoaky-tiny @TheSpyder @ltrouton