Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] : Add expressoft colorscheme #18

Closed
wants to merge 2 commits into from

Conversation

Yushi5058
Copy link

Hello,
I would like to add my own colorscheme to the base16 category.
Source repo : here
Thanks

@RobLoach
Copy link
Contributor

You may want to make sure it's using the right spec.

@Yushi5058
Copy link
Author

You may want to make sure it's using the right spec.

Hello, what do you mean by that ? There is only one branch with a spec name on it.

@JamyGolden
Copy link
Member

Hi, you should add a variant property, indent the palette properties and I recommend ordering the scheme palette this way:

system: "base16"
name: "expressoft"
author: "Yushi5058"
variant: "dark"
palette:
  base00: "120d09"
  base01: "241b13"
  base02: "372b20"
  base03: "4b3c2e"
  base04: "766454"
  base05: "8f7c6d"
  base06: "aa998b"
  base07: "cabeb3"
  base08: "9c4473"
  base09: "9c6d44"
  base0A: "9c6d44"
  base0B: "739c44"
  base0C: "449c6d"
  base0D: "44739c"
  base0E: "6d449c"
  base0F: "44479c"

The palette will look as follows:

image

As you can see the yellow/orange is duplicated on base09 and base08. Perhaps you could also find a more yellow colour for base0A for added variation. Have a look at the styling spec for more information.

@JamyGolden JamyGolden self-requested a review August 28, 2024 11:17
@JamyGolden
Copy link
Member

I'm going to close this since there hasn't been any movement in some months but I can reopen if you want to continue with it.

@JamyGolden JamyGolden closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants