Allow checkForModule to match child module names w/ arbitrary paths #208
Conversation
|
Hi @quinnj Thanks for using the plugin and for your PR. Please, just change the commit message so it matches the conventional commit convention of the project, as sunch: This will allow semantic release. Thanks |
…le names w/ arbitrary paths
|
Thanks for the review @tinesoft! Pushed! |
|
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We have a use-case where we have a root gradle project (e.g. in
root/), and then gradle subprojects that live in various subdirectories (e.g.root/apps/cool-app,root/libs/api/cool-lib).The problem is that our root level build.gradle then has entries like:
And the current
checkForModuleassumes the subproject always lives in the same directory as root.With the proposed regex change here, we can ensure the nx executors work correctly for
nx build cool-app.