Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep improving CI #292

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Keep improving CI #292

merged 3 commits into from
Feb 4, 2025

Conversation

BryanQuigley
Copy link
Collaborator

this includes spellcheck for both other files and markdown
updated lint script that has more options - including formatting
enabled markdown link checker as the first pass on making sure links work
update CI to only activate on changed files

Copy link
Collaborator

@lydiascarf lydiascarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i like the linter running only on changes by default, and it ran as expected when i tested it.

i tested against odp as well and it was mostly good! the only thing was we have this line in our megalinter config:

BASH_SHFMT_ARGUMENTS: "-i 4"

and cspell didn't like "SHFMT". this env is telling the bash linter to use 4 spaces instead of tabs, which i like. maybe we should add that in here as well and address the cspell error before merging

this includes spellcheck for both other files and markdown
updated lint script that has more options - including formatting
enabled markdown link checker as the first pass on making sure links work
update CI to only activate on changed files
@BryanQuigley BryanQuigley merged commit 8101769 into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants