Merge pull request #1 from timotta/p10

Python 3.10

.github/workflows/python-publish.yml

@@ -17,22 +17,39 @@ permissions:
   contents: read
 
 jobs:
-  deploy:
-
+  quality:
+    strategy:
+      matrix:
+        version: ['3.10', '3.11']
     runs-on: ubuntu-latest
-
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python
       uses: actions/setup-python@v3
       with:
-        python-version: '3.11'
+        python-version: ${{ matrix.version }}
     - name: Install
       run: make install
     - name: Lint
       run: make lint
     - name: Test
       run: make test
+
+  deploy:
+    runs-on: ubuntu-latest
+    needs: quality
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python
+      uses: actions/setup-python@v3
+      with:
+        python-version: '3.11'
+    - name: Build
+      run: make build
+      env:
+        VERSION: ${{ steps.version.outputs.id }}
+    - name: Install
+      run: make install
     - name: Get version
       id: version
       uses: iawia002/get-tag-or-commit-id@v1

.github/workflows/quality.yml

@@ -6,16 +6,17 @@ permissions:
   contents: read
 
 jobs:
-  deploy:
-
+  quality:
+    strategy:
+      matrix:
+        version: ['3.10', '3.11']
     runs-on: ubuntu-latest
-
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python
       uses: actions/setup-python@v3
       with:
-        python-version: '3.11'
+        python-version: ${{ matrix.version }}
     - name: Install
       run: make install
     - name: Lint

positional_vectorizer/__init__.py

@@ -1,9 +1,15 @@
 from sklearn.feature_extraction.text import _VectorizerMixin
 from sklearn.base import BaseEstimator
-from typing import Self, List
+from typing import List
 from scipy.sparse._csr import csr_matrix
 import math
 
+# Python 3.10 has no Self on typing module
+try:
+    from typing import Self  # type: ignore[attr-defined]
+except Exception:
+    from typing_extensions import Self
+
 
 class PositionalVectorizer(_VectorizerMixin, BaseEstimator):
 

requirements.txt

@@ -1 +1,2 @@
-scikit-learn>=1.4.2
+scikit-learn>=1.4.2
+typing-extensions>=4.11.0

setup.py

@@ -35,6 +35,6 @@ def read_multiline_as_list(file_path: str) -> List[str]:
             # '',
         ],
     },
-    python_requires=">=3.11, <3.12",
+    python_requires=">=3.10, <3.12",
     install_requires=requirements,
 )