This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Update to modernize gems and deps #15
Open
samnissen
wants to merge
10
commits into
timkoopmans:master
Choose a base branch
from
samnissen:update-to-modernize-gems-and-deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to modernize gems and deps #15
samnissen
wants to merge
10
commits into
timkoopmans:master
from
samnissen:update-to-modernize-gems-and-deps
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@90kts Hello. Can this be reviewed? Thanks! |
if you are still waiting for this I've released watir-performance that is updated version of this repo. |
Hey sorry I can't maintain this anymore. @MacCracken @samnissen would either of you two like to take ownership/transfer of this repository? |
@90kts I can take that on. Let me know if you need anything from me to make it happen |
I’ve already made the newer gem on rubygems...
Called watir-performance (https://rubygems.org/gems/watir-performance) so you can just update the readme to point to mine for watir use and archive the repo please. or just give it to me so I can archive it. It makes no sense to continue development on this gem since watir-webdriver is a retired/archived project now too.
|
@90kts @MacCracken I'm not opposed to that plan, though I believe any successor to this gem should maintain the connection to this repo through a GitHub fork. I'm glad to help pitch in on whatever. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
But it got a bit messy, mostly due to my lack of experience crafting gems. Specifically I'll call out:
before
andafter
context blocks that aren't being used, but obviously that's a style decision you might want to reverse.