feat(Launcher): improve UX #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show smaller rows - rename column 'Player Count' to 'Players'
- use fixed width for players, ip, version and favorite columns. - fill the remaining space with name and tags columns. - remove redundant DOM elements and width attributes in ServerRow.
- show message when filter yield no results. - show message when no servers are online. - improve maintainability.
poirierlouis
force-pushed
the
feat/improve-ux
branch
from
b438496 to
8ab71bf
Compare
|
We could remove the address field all together. I don't see a reason to show it to users. |
I think it is better, and still important, to show the address of the server. At least for a user to make sure the address is the expected one. No? |
|
Hmm maybe, I am not sure how other games do it |
|
Maybe we can keep it for now, but remove it when Discord auth is implemented? As I guess, it will be enough for the user to identify the server safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
Preview:
