Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Launcher): autodetect game path #11

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

poirierlouis
Copy link
Collaborator

Toast = Snackbar

Implemented:

  • test three commons path to auto-detect game executable file
  • show toasts to user when file is detected or not
  • prompt user to select file otherwise
  • add error/warning/success toasts to be improved for reusability across the entire app

Should wait for #8 before merging this PR.

@poirierlouis poirierlouis marked this pull request as ready for review November 24, 2024 12:21
Prevent requests to server list endpoint from failing constantly while developing.
Toast = Snackbar

- test three commons path to auto-detect game executable file
- show toasts to user when file is detected or not
- prompt user to select file otherwise
- add error/warning/success toasts to be improved for reusability across the entire app
@maximegmd maximegmd merged commit f0636c6 into tiltedphoques:main Nov 24, 2024
2 checks passed
@poirierlouis poirierlouis deleted the feat/detect-exe branch November 24, 2024 15:00
@poirierlouis poirierlouis self-assigned this Nov 25, 2024
@poirierlouis poirierlouis added launcher enhancement New feature or request labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request launcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants