region_request: tiny refactor - init function failpointSendReqResult #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndreMouche <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
AndreMouche
requested review from
crazycs520,
MyonKeminta and
ekexium
and removed request for
crazycs520 and
MyonKeminta
ekexium
approved these changes
Dec 17, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
MyonKeminta
reviewed
Dec 24, 2024
internal/locate/region_request.go
Outdated
Comment on lines
1903
to
1910
| val, e := util.EvalFailpoint("tikvStoreSendReqResult") | ||
| if e != nil { | ||
| return | ||
| } | ||
| errMsg, ok := val.(string) | ||
| if !ok { | ||
| return | ||
| } |
There was a problem hiding this comment.
It's ok to just follow the original pattern if val, err := util.EvalFailpoint("tikvStoreSendReqResult"); err == nil { ..., instead of reformatting it. It's actually the expanded version of the failpoint.Inject pattern.
Signed-off-by: AndreMouche <[email protected]>
MyonKeminta
approved these changes
Jan 2, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: AndreMouche <[email protected]>
MyonKeminta
approved these changes
Jan 2, 2025
ekexium
approved these changes
Jan 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the logic of handling failpoint
tikvStoreSendReqResultinto a function to make the main logic ofSendReqCtxfunction more concise and friendly to maintain.