Add iterations to Connect keyword #238
Merged
+34
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaarine
approved these changes
Feb 11, 2025
leivos-unikie
force-pushed
the
interate_x1_connection
branch
2 times, most recently
from
e9e79e2 to
c090604
Compare
Since Connect keyword is used in so many places I lower the default to 1 iterations but give 10 iterations in those cases when Connect is used after boot or reboot on lenovo-x1. |
leivos-unikie
force-pushed
the
interate_x1_connection
branch
7 times, most recently
from
7d96bb6 to
7f5e66f
Compare
leivos-unikie
force-pushed
the
interate_x1_connection
branch
4 times, most recently
from
98779fe to
a66f561
Compare
milva-unikie
approved these changes
Feb 13, 2025
After ethernet interface was passed through to net-vm on lenovo-x1 iterative check of login to net-vm was first added to boot tests of lenovo-x1. Fails after gui reboot tests showed that connection iterations need be added also after gui reboot, namely every time the device boots or reboots. Decided to put the default number of iterations in Connect keyword to 1 (as before) and give more iterations only when it is used after boot or reboot. Signed-off-by: Samuli Leivo <[email protected]>
leivos-unikie
force-pushed
the
interate_x1_connection
branch
from
a66f561 to
46d011a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ethernet interface was passed through to net-vm on lenovo-x1 iterative check of login to net-vm was first added to boot tests of lenovo-x1. Failures after gui reboot tests showed that iterations have to be added to the Connect keyword instead of using them only in the boot test.
The default number of iterations in Connect is 1 (as previous) but in boot tests and gui reboot 10 iterations are given.
Also Orin-NX needs to have iterative Connect keyword at boot and the output target has to be net-vm as with lenovo-x1. Both lenovo-x1 and orin-nx expose ghaf-host for about 10 sec time window at boot. During that time window ssh login attempts end up to ghaf-host.
Modified also
Connect to ghaf hostto connect via net-vm on Orin-NX (as with lenovo-x1).Removed orin-nx tag from those test cases which include stopping net-vm.
Connect to ghaf hostin optee suite setup instead of plainConnectSwitching between connections didn't work anymore in
Verify NetVM PCI device passthrough. Fixed that.