Display locations on conference list #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
requested changes
Jan 6, 2025
| @@ -73,8 +73,8 @@ public function import(Event $event) | |||
| ->firstOrNew(['calling_all_papers_id' => $event->id]); | |||
| $this->updateConferenceFromCallingAllPapersEvent($conference, $event); | |||
|
|
|||
| if (! $conference->latitude && ! $conference->longitude && $conference->location) { | |||
| $this->geocodeLatLongFromLocation($conference); | |||
| if ($conference->location) { | |||
There was a problem hiding this comment.
This isn't checking if latitude and longitude are set, which means we'll run the geocoder every single time, drastically increasing our costs.
There was a problem hiding this comment.
It's probably worth adding a test to ensure geocodeLocation isn't called if latitude and longitude or set, so this isn't every accidentally broken in the future.
| { | ||
| protected $signature = 'app:backfill-conference-location-names'; | ||
|
|
||
| protected $description = 'Command description'; |
| public function geocode(string $address): Coordinates | ||
| private $response; | ||
|
|
||
| public function geocode(string $address): self |
There was a problem hiding this comment.
You've modified this class to now represent the results of a geocoding operation. Two issues:
- You have a bunch of methods that can fail, if you haven't run
geocodeyet. That meansgeocodeneeds to become the constructor, so you can't have an instance of this object that doesn't have aresponseproperty. - This is no longer a
Geocoderservice. it's now a representation of a single geocode request. So you'll want to rename it to something that better reflects that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #519 by adding the conference location to the conferences list page. This PR also adds a
app:backfill-conference-location-namesto backfill a display-friendly conference location. Each conference listing will then display either the conference's location name, or the value in thelocationcolumn, if present.