Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sonor cloud issue 8-2 #1471

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix/sonor cloud issue 8-2 #1471

merged 2 commits into from
Dec 5, 2024
+7 −7

Conversation

takanotaiga
Copy link
Member

Description

Abstract

This PR includes modifications based on the results of static analysis performed by SonarCloud. Please refer to the SonarCloud reference for details on the issue fixes.

Background

N/A

Details

N/A

References

This PR has been split and submitted to avoid the issues that occurred in the following PR.

Replace the redundant type with "auto".

implicit conversion loses floating-point precision: 'double' to 'const float'

Remove this redundant cast.

unused exception parameter 'e'

Destructive Changes

N/A

Known Limitations

N/A

@takanotaiga
Replace the redundant type with "auto".
3237f65 
Remove this redundant cast.
Remove unused exception parameter 'e'
implicit conversion loses floating-point precision: 'double' to 'const float'
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited by hakuturu583
Loading

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@takanotaiga takanotaiga self-assigned this Dec 3, 2024
@takanotaiga takanotaiga added refactor bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Dec 3, 2024
@takanotaiga takanotaiga changed the title Fix/sonor cloud issue 8 Fix/sonor cloud issue 8-2 Dec 4, 2024
@takanotaiga takanotaiga marked this pull request as ready for review December 4, 2024 00:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hakuturu583 hakuturu583 merged commit fd9d083 into master Dec 5, 2024
14 checks passed
@github-actions github-actions bot deleted the fix/sonor-cloud-issue-8-2 branch December 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

Assignees

@takanotaiga takanotaiga

Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor wait for regression test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takanotaiga @hakuturu583