Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -Wreorder warnings in test extcutor class #1225

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Apr 8, 2024

Description

Abstract

remove -Wreorder warning from random_test_runner package.

Background

There was a problem with the initialization order of variables, causing a -Wreorder warning.

Details

Fixed initialization order and fixed Wreorder warning inside random_test_runner package.

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Apr 8, 2024
@hakuturu583 hakuturu583 self-assigned this Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 requested a review from HansRobo April 8, 2024 08:49
@hakuturu583 hakuturu583 marked this pull request as ready for review April 8, 2024 08:49
@HansRobo HansRobo merged commit 6ebc9aa into master Apr 8, 2024
15 checks passed
@HansRobo HansRobo deleted the fix/remove_warnings_from_random_test_runner branch April 8, 2024 09:42
@github-actions github-actions bot restored the fix/remove_warnings_from_random_test_runner branch April 8, 2024 09:43
@github-actions github-actions bot deleted the fix/remove_warnings_from_random_test_runner branch April 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants