-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete workflow feature and add alternative bash script #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
# Conflicts: # test_runner/scenario_test_runner/config/workflow_example.yaml
yamacir-kit
requested changes
Apr 16, 2024
Co-authored-by: Tatsuya Yamasaki <[email protected]>
yamacir-kit
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
scenario_test_runner
to simplify itBackground
The workflow feature was considered necessary at the initial stage of
scenario_simulator_v2
.However, over time, we found that the workflow feature did not provide useful functionality to justify the added complexity of the data flow.
And I'm removing this feature in this pull-request as a simple script can replace it.
Details
usage for new script
workflow file example
A file with a scenario path written on each line is valid.
It is passed to the scenario specification part of
scenario_test_runner
, so special commands such asfind-pkg-share
can be used.script exit status
The script's exit status is 1 if even one scenario fails, and 0 if all are successful.
References
Regression Test Result: OK
Destructive Changes
Workflow functionality has been removed.
Users must create their own replacement functionality.
A simple sample is included in this pull request for your reference.
Known Limitations
N/A