Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: develop merge for v0.2.3 #257

Merged
merged 1 commit into from
Feb 4, 2025
Merged

chore: develop merge for v0.2.3 #257

merged 1 commit into from
Feb 4, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 4, 2025

We decided on trunk-based development for now, so this will be the last develop merge - the branhc will be deleted afterwards.

PRs that will be merged from develop into main:

* Added XT16 references, added XT16 packet header file, added XT16 params and correction files.
TO DO:
- Check nebula_tests/hesai/hesai_ros_decoder_test_main.cpp
- Check hardware and launch files
- Run tests

Signed-off-by: jemmmel <[email protected]>

* Added test pcd for xt16

Signed-off-by: jemmmel <[email protected]>

* Added XT16 to docs, modified max_scan_buffer_points, changed struct to use TailXT32

* Added header for XT32 packet struct

Co-authored-by: Max Schmeller <[email protected]>

* Added missing vendor file

Signed-off-by: jemmmel <[email protected]>

* Updated json for XT16 with changes from develop

Signed-off-by: jemmmel <[email protected]>

---------

Signed-off-by: jemmmel <[email protected]>
Co-authored-by: Max Schmeller <[email protected]>
@mojomex mojomex changed the title feat(hesai): add support for xt16 (#241) chore: develop merge for v0.2.3 Feb 4, 2025
@mojomex mojomex self-assigned this Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 27.27%. Comparing base (6eb72b5) to head (2241b61).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ers/nebula_decoders_hesai/decoders/pandar_xt16.hpp 75.00% 2 Missing and 1 partial ⚠️
...ommon/include/nebula_common/hesai/hesai_common.hpp 0.00% 2 Missing ⚠️
...ula_common/include/nebula_common/nebula_common.hpp 60.00% 1 Missing and 1 partial ⚠️
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% 2 Missing ⚠️
.../nebula_hw_interfaces_hesai/hesai_cmd_response.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   27.17%   27.27%   +0.10%     
==========================================
  Files         104      105       +1     
  Lines        9444     9465      +21     
  Branches     2328     2337       +9     
==========================================
+ Hits         2566     2582      +16     
- Misses       6432     6435       +3     
- Partials      446      448       +2     
Flag Coverage Δ
differential 27.27% <60.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex merged commit f21a4a0 into main Feb 4, 2025
12 of 13 checks passed
@mojomex mojomex deleted the develop branch February 4, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants