fix(autoware_pointcloud_preprocessor): empty input validation (#10115) #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refoundation#10115) * fix(autoware_pointcloud_preprocessor): fix 0 division Signed-off-by: Shumpei Wakabayashi <[email protected]> * style(pre-commit): autofix * fix float and error throttle Signed-off-by: Shumpei Wakabayashi <[email protected]> * style(pre-commit): autofix * fix Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix param validation Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix unused var Signed-off-by: Shumpei Wakabayashi <[email protected]> * feat add input validatoin Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix too cautious floating Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix error msg Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix plural Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix: set exclusiveMinimum 0.0 Signed-off-by: Shumpei Wakabayashi <[email protected]> * fix: reomve unnecessary validatoin Signed-off-by: Shumpei Wakabayashi <[email protected]> --------- Signed-off-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
rej55
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix crash in the PickupBasedVoxelGridDownsampleFilterComponent when processing empty point cloud data.
cherry-pick autowarefoundation#10115
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.