Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_velocity_traffic_light_module): add v2i to behavior_velocity_traffic_light #1774

Merged
merged 14 commits into from
Feb 3, 2025

Conversation

yhisaki
Copy link

@yhisaki yhisaki commented Jan 16, 2025

Description

Add V2I functionality to `autoware_behavior_velocity_traffic_light_module'.
This PR is a cherry-pick from this PR.
Details are described in this PR.

Related links

Before we merge this, we need to merge the following PRs.

How was this PR tested?

Tested on Psim.

Screencast.from.01-16-2025.10.23.12.PM.webm

Notes for reviewers

Implemented for limited use in tier4 repositories

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior_velocity_planner and behavior_velocity_planner_common, which will be located in the autoware.core, cannot depend on temporal messages.

@tier4-githubadmin tier4-githubadmin force-pushed the awf-latest branch 8 times, most recently from 9f5d33b to 76b86d8 Compare January 23, 2025 07:54
@yhisaki yhisaki force-pushed the feat/traffic_light-v2i branch from 2fe9469 to 317bf1b Compare January 23, 2025 08:08
@yhisaki yhisaki assigned soblin and yuki-takagi-66 and unassigned soblin Jan 30, 2025
Copy link

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTC周りは問題ないかと思います。
rebase漏れがありそうなので、お願いします。

.github/sync-files.yaml Outdated Show resolved Hide resolved
Copy link

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tier4-githubadmin tier4-githubadmin force-pushed the awf-latest branch 2 times, most recently from fca179d to 2684bad Compare January 30, 2025 07:54
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

not sync github-release

Signed-off-by: Yutaka Kondo <[email protected]>
@tier4-githubadmin tier4-githubadmin force-pushed the awf-latest branch 3 times, most recently from 05d8f4d to 36ce681 Compare January 31, 2025 04:54
not sync github-release

Signed-off-by: Yutaka Kondo <[email protected]>
yhisaki and others added 3 commits January 31, 2025 17:46
@TomohitoAndo TomohitoAndo self-requested a review January 31, 2025 09:45
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhisaki yhisaki merged commit dfa2719 into awf-latest Feb 3, 2025
24 of 26 checks passed
@yhisaki yhisaki deleted the feat/traffic_light-v2i branch February 3, 2025 10:32
Copy link

sonarqubecloud bot commented Feb 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants