feat: optimize voxel indexing in preprocess_kernel.cu #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Currently waiting for the discussion results in autowarefoundation#9608, but I think we can merge this since v4.0.1 is tentative and running in our test drive will prove safety in this PR. |
|
@YoshiRi autowarefoundation#9608 has been merged. |
|
Merge this after following PR → OK now I will merge this. |
technolojin
added a commit
that referenced
this pull request
Dec 26, 2024
* Merge pull request #1688 from technolojin/feat/centerpoint/voxel-fill-from-front feat: optimize voxel indexing in preprocess_kernel.cu Signed-off-by: Taekjin LEE <[email protected]> * fix: clip the index in range Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: Yoshi Ri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
alternative of PR #1672
description: please see autowarefoundation#9608
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.