-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/freeflow #1033
base: development
Are you sure you want to change the base?
Feature/freeflow #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments due to
Deployment process
- the placeholder for the name filed said
Your 3bot Name
and looking into the code it is not used for any special envars just the name of the machine(s) models. so it it required to be the 3bot name? if the 3bot username is needed we can add another field thanName
since this should be unique for each deployment. - Can you please use the
SelectCapacity
component to be able to choose a flavor for capacity or set it manually? - it looks that the server on the machine bind on both ipv6/ipv4 so the gateway can have the backend as planetary IP and make the solution doesn't require a public IP. since it has higher cost
- the modal box did not work after the instance is deployed.
Deployment list
- there is should be an actions column in the deployments table that does (show the details, go to the domain created, others if needed ) but there is none. please check the deployment list for other weblets
Flist
- can you use zinit as the PID 1 service for the solution? it will make it easier to trace the logs back if something goes wrong.
- all flists should be promoted to be at the official-apps repo on flists hub.
https://hub.grid.tf/tf-official-apps/freeflow.flist
almost all the code base follows the formatting form extensions
|
Some remarks: Deployment processFirst of all, the reason why your 3bot name is not recognized is because the FList is deployed with the staging ThreeFold Connect Authenticator. I will change this to production enviroment. Furthermore, the ThreeFold Connect 3bot name is necessary (not just a random chosen name), because a login attempt will be setup specific for the 3bot name. If the user will log in with another account, the authentication process will throw an error. This is intended, otherwise you could impersonate yourself as someone else. Eg; I am trying to login in a FreeFlow container of Lennert00. So I am just changing the name in the login screen from Lennert00 to Lennert11. I am accepting the login attempt inside the app with Lennert11. This wont work since the login attempt is created for Lennert00 and is accepted by Lennert11. Conclusion: the right 3botname is needed to authenticate to your FreeFlow. Good remark with adding SelectCapacity to the form + agreed with binding IPV6 to the backend. Deployment listI will add some more details such as the DNS name in the deployment table, so users easily can navigate to their own FreeFlow container. FlistI will change the startup process to zinit. Am I able to push an flist to push content on the official-apps repo? If yes, how can I do this? Other remarkThe reason why I made a seperate validateThreeBotName is since a 3bot name can container more than 15 characters. So indeed, using the 3bot name as name for the VM is not the right method. I'll fix this by adding a unique name for each deployment, but a function which validates the 3bot name is still necessary. |
since the 3bot name and the deployment name will be different fields it is okay to have different validations for both. and for pushing the flist to the official repo. after you finish all the updates and test it we can ask Maxime to push it. |
Updated PR:Deployment process
Deployment list
Flist stuff
Todo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/utils/deployFreeFlow.ts
Outdated
vm.env = createEnvs(envs); | ||
|
||
const vms = new MachinesModel(); | ||
vms.name = threeBotUserId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot to change that name too ^^
Yeah, noticed this problem too, even if I deleted all of my contracts on devnet, a new NamedGateway with a previous created name (which is already) deleted, cant be deployed.
See: https://github.com/threefoldtech/test_feedback/issues/299
|
Updated PR:
Todo:
|
|
Updated PR with unique networkname + merged back again with development. Also added the new capacity selector component Added a comment to the issue of the DNS gateways, had no named contracts in the contract list, so still stuck on this issue => but cant really help on that I think |
Update:added checkGW before deploying the gateway to invalidate cache Now all issues should be resolved |
Weblets
please check the code in Image. |
PR is updated |
…ets into feature/freeflow
PR has been updated, since inside update of freeflow, yggdrasil process got respawned with new keys which required us to communicate over ipv6 from gateway to backend instead of yggdrasil |
Any updates on the IPV6 filter for gateways? for communication over IPv6 |
Description
In this PR, support of FreeFlow (https://github.com/threefoldtech/twin_aydo) on Gridv3 will be available through UI.
Changes
Related Issues
threefoldtech/tfgrid-sdk-ts#129