-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rented by me and include rentable nodes filter #3852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to have a rentedbyMe to be passed to the filters; we can have computed value that returns the twinid or undifinded based on the rentedByMe toggle value and pass it to the rentedby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
freeflow is not updated with new changes, please check
It's not a part of the dashboard applications anymore |
It should be added; we may reuse the application again; then the component should be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will test caprover worker later when we have node that have ipv4 rentable
Co-authored-by: Omar Kassem <omarksm09@gmail.com>
I suggest changing the should we update the tooltip to be learn more about rentable nodes? make sure to pull the development branch |
I agree with renaming but for turning on my rented nodes filter will list only my nodes so if it doesn't satisfy the requirements it will show no nodes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need nodes
word here as we do in certified

Rented by me (only)
Rentable
Certified
also the tooltip i think should changed as i mentioned
@ehab-hassan what do you think?
Description
Add rented by me and include rentable nodes filter
Changes
Screencast.from.17-02-25.20.42.05.webm
Updated filters
Related Issues
Tested Scenarios
Documentation PR
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist