Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gateway query to enable only domain and ipv4 in gridProxy requests #3851

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jan 30, 2025

Description

  • all of scripts, and tests are using capacity.filterNodes

  • all dashboard solutions including manage domains and domain solustion are using TFDomainName which is using capacity.filterNodes

  • node finder only i added the ipv4 based on the gateway togle value

Changes

  • chore(Nodes:Capacity[FilterNodes]): set only ipv4 and domain with true on gateway query removing ipv6
  • chore(NodeFinder:Gateway): set ipv4 with true if the gateway option is enabled

Related Issues

#3850

Tested Scenarios

  • deployed wordpress instance with gateway
  • nightly and tests workflow are not complaing about gateways
  • dashboard lists gateway nodes normally

https://github.com/threefoldtech/tfgrid-sdk-ts/runs/36423359445

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about here

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 2, 2025

what about here

this related to worker, not domain name or gateway

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Feb 2, 2025

sentry keeps throwing this err when I select gateways filter in node finder.
image
My bad, seems like a problem with sentry unrelated to this PR

@0oM4R 0oM4R requested a review from amiraabouhadid February 2, 2025 11:47
@amiraabouhadid
Copy link
Contributor

tested with taiga, works
image
please merge development into this branch to avoid this err
image

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 2, 2025

please note that the gateway tests are not passign and tracked on #3857

@amiraabouhadid
Copy link
Contributor

still having trouble running yggdrasil locally @maayarosama can you please check scripts?

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works with peertube too

@0oM4R 0oM4R merged commit 1468272 into development Feb 5, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants