Using generateString in all scripts that deploy a machine

[maayarosama]

Description

Using generateString in all scripts that deploy a machine

Related Issues

• random name generation in scripts #3804

Tested Scenarios

• run scripts

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[amiraabouhadid]

issue isn't just for scripts that deploy a VM, please update PR title and scripts accordingly . I'd do a global search for 'name' in scripts and add generateString() for matches

[maayarosama]

issue isn't just for scripts that deploy a VM, please update PR title and scripts accordingly . I'd do a global search for 'name' in scripts and add generateString() for matches

I'm not sure what scripts exactly you want me to change, so can you please provide me with the scripts?

[amiraabouhadid]

for example:

tfgrid-sdk-ts/packages/grid_client/scripts/algorand.ts

Line 26 in 88715bd

const name = "testAcc";

tfgrid-sdk-ts/packages/grid_client/scripts/algorand.ts

Line 30 in 88715bd

name: "myaccount",

tfgrid-sdk-ts/packages/grid_client/scripts/algorand.ts

Line 46 in 88715bd

description: "test",

tfgrid-sdk-ts/packages/grid_client/scripts/algorand.ts

Line 68 in 88715bd

description: "test",

tfgrid-sdk-ts/packages/grid_client/scripts/blockchain.ts

Line 23 in 88715bd

name: "createAlgorand",

tfgrid-sdk-ts/packages/grid_client/scripts/blockchain.ts

Line 27 in 88715bd

name: "createStellar",

tfgrid-sdk-ts/packages/grid_client/scripts/blockchain.ts

Line 32 in 88715bd

name: "createTfchain",

tfgrid-sdk-ts/packages/grid_client/scripts/blockchain.ts

Line 42 in 88715bd

name: "stellarClient",

[0oM4R]

I could run the script twice, i have 2 deployments

but in the deployment list we have to deployements with same name

i suggest to add the random string as postfix to the machine.name

[0oM4R]

deployed two VMS and got only one network wedtest I'm not sure if we have to use random string in the network name as well

[0oM4R]

also what about storing the random string and reuse it in the file, instead of generating 2 or 3 random strings