refactor state loader functions get all node deployments at once #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
rawdaGastan
requested changes
Jan 15, 2025
| if len(strings.TrimSpace(dl.Metadata)) == 0 { | ||
| return zosTypes.Workload{}, zosTypes.Deployment{}, errors.Wrapf(err, "contract %d doesn't have metadata", contractID) | ||
| } | ||
| return zosTypes.Workload{}, zosTypes.Deployment{}, errors.Wrapf(err, "contract %d doesn't have metadata", dl.ContractID) |
There was a problem hiding this comment.
why checking metadata twice?
| if err != nil { | ||
| return zosTypes.Workload{}, zosTypes.Deployment{}, errors.Wrapf(err, "could not get node client: %d", nodeID) | ||
| } | ||
| nodeClient, err := st.NcPool.GetNodeClient(sub, nodeID) |
There was a problem hiding this comment.
why getting node client before checking deployments condition
| if err != nil { | ||
| return zosTypes.Workload{}, zosTypes.Deployment{}, errors.Wrapf(err, "could not get deployment %d from node %d", contractID, nodeID) | ||
| return zosTypes.Workload{}, zosTypes.Deployment{}, errors.Wrapf(err, "could not get contract %d from node %d", dl.ContractID, nodeID) |
There was a problem hiding this comment.
what is the error checked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the state tries to load every deployments one by one from the nodes to be able to get a workload
Changes
I used the
nodeClient.DeploymentListto load all deployments at once instead of doing multible rmb requests.Related Issues
state.LoadNetworkFromGrid#856Checklist