Skip to content

Commit

Permalink
fix(client:go): remove identity param for gpu status getter (#749)
Browse files Browse the repository at this point in the history
  • Loading branch information
DylanVerstraete authored Jun 16, 2023
1 parent b98807b commit ef4ef7d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion clients/tfchain-client-go/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ func (s *Substrate) SetNodeGpuStatus(identity Identity, state bool) (hash types.
return callResponse.Hash, nil
}

func (s *Substrate) GetNodeGpuStatus(identity Identity, nodeId uint32) (status bool, err error) {
func (s *Substrate) GetNodeGpuStatus(nodeId uint32) (status bool, err error) {
cl, meta, err := s.GetClient()
if err != nil {
return status, err
Expand All @@ -846,6 +846,10 @@ func (s *Substrate) GetNodeGpuStatus(identity Identity, nodeId uint32) (status b
return status, errors.Wrap(err, "failed to lookup gpu status")
}

if raw == nil || len(*raw) == 0 {
return false, nil
}

if err := Decode(*raw, &status); err != nil {
return status, errors.Wrap(err, "failed to load object")
}
Expand Down
4 changes: 2 additions & 2 deletions clients/tfchain-client-go/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,15 @@ func TestNodeUpdateGpuStatus(t *testing.T) {
_, err = cl.SetNodeGpuStatus(identity, true)
require.NoError(t, err)

status, err := cl.GetNodeGpuStatus(identity, nodeID)
status, err := cl.GetNodeGpuStatus(nodeID)
require.NoError(t, err)
require.Equal(t, true, status)

// toggle false
_, err = cl.SetNodeGpuStatus(identity, false)
require.NoError(t, err)

status, err = cl.GetNodeGpuStatus(identity, nodeID)
status, err = cl.GetNodeGpuStatus(nodeID)
require.NoError(t, err)
require.Equal(t, false, status)
}

0 comments on commit ef4ef7d

Please sign in to comment.