Update systemd unit file #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set a nicer unit description. - Use `network.target` instead of `network-online.target`. As per https://www.freedesktop.org/software/systemd/man/latest/systemd.special.html#network-online.target, mycelium doesn't strictly require a configured network connection (whatever that means). `network.target` should be sufficient, we probably need the IP stack and a loopback interface, but everything else should be OK to change later on. - Use `StateDirectory=mycelium` and -k `%S/mycelium-key.bin`. Key material is state, not config, especially if it's autocreated on first startup. Combine with `StateDirectoryMode=0700`, to ensure the directory can't be accessed by other users.
flokli
force-pushed
the
systemd-unit-updates
branch
from
ccef021 to
ed959c7
Compare
|
Thanks. From the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network.targetinstead ofnetwork-online.target. As per https://www.freedesktop.org/software/systemd/man/latest/systemd.special.html#network-online.target, mycelium doesn't strictly require a configured network connection (whatever that means).network.targetshould be sufficient, we probably need the IP stack and a loopback interface, but everything else should be OK to change later on.StateDirectory=myceliumand -k%S/mycelium-key.bin. Key material is state, not config, especially if it's autocreated on first startup. Combine withStateDirectoryMode=0700, to ensure the directory can't be accessed by other users.