Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mode when creating key file #134

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 27, 2024

Make sure a generated key file is not readable by others.

This ensures the file is not group/world-readable.

Before:

❯ ls -la /var/lib/mycelium/key.bin
-rw-r--r-- 1 root root 32 Feb 27 20:18 /var/lib/mycelium/key.bin

After:

❯ ls -la /var/lib/mycelium/key.bin
-rw------- 1 root root 32 Feb 27 20:34 /var/lib/mycelium/key.bin

@flokli flokli force-pushed the keyfile-mode branch 2 times, most recently from d367313 to 59a7d76 Compare February 27, 2024 18:57
@flokli
Copy link
Contributor Author

flokli commented Feb 27, 2024

I don't know why clippy on windows keeps failing, but seems unrelated:

Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration

@LeeSmet
Copy link
Contributor

LeeSmet commented Feb 27, 2024

The (current) clippy CI action has a limitation that it doesn't have the ability to put up anotations for PR's from forked repo's. The Issue is that the import for tokio::fs::OpenOptions isn't used on windows.

Could you change the code to either use a fully qualified path for OpenOptions, or add the import for it inside the unix { .. } block?

Make sure a generated key file is not readable by others.

This ensures the file is not group/world-readable.
@flokli
Copy link
Contributor Author

flokli commented Feb 27, 2024

Done, and CI is now green!

@LeeSmet LeeSmet merged commit 9feff08 into threefoldtech:master Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants