SCAL-241097 Fix for liveboard shound not rerender if parent component…

… rerenders
thoughtspot · Feb 4, 2025 · 6b2c054 · 6b2c054
1 parent facf4a5
commit 6b2c054
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/react/index.tsx b/src/react/index.tsx
@@ -23,9 +23,8 @@ const componentFactory = <T extends typeof TsEmbed, U extends EmbedProps, V exte
     (props: U, forwardedRef: React.MutableRefObject<InstanceType<T>>) => {
         const ref = React.useRef<HTMLDivElement>(null);
         const { className, ...embedProps } = props;
-        const { viewConfig, listeners } = getViewPropsAndListeners<Omit<U, 'className'>, V>(
-            embedProps,
-        );
+        const { viewConfig, listeners } = React.useMemo(() => getViewPropsAndListeners<Omit<U, 'className'>, V>(embedProps),
+            [embedProps]);
 
         const handleDestroy = (tsEmbed: InstanceType<T>) => {
             // do not destroy if it is a preRender component