update types for tooltip config item #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9871452 |
harshmeetTS
force-pushed
the
feat/add-default-tooltip-from-TS
branch
from
0516949 to
22e56ee
Compare
| @@ -74,9 +74,6 @@ export enum TSToChartEvent { | |||
| */ | |||
| AxisMenuActionClick = 'AxisMenuActionClick', | |||
|
|
|||
| /** | |||
| * @version SDK: 0.2 | ThoughtSpot: | |||
There was a problem hiding this comment.
Why it is removed @harshmeetTS ?
There was a problem hiding this comment.
I think it was a mistake will add it back
harshmeetTS
force-pushed
the
feat/add-default-tooltip-from-TS
branch
from
c41c0b4 to
2d546b6
Compare
yashvardhan-n
approved these changes
Dec 9, 2024
| @@ -188,10 +188,17 @@ export type SuccessValidationResponse = { | |||
| visualPropEditorDefinition: VisualPropEditorDefinition; | |||
| }; | |||
|
|
|||
| export type VisualPropError = { | |||
There was a problem hiding this comment.
nit: can we add type definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.