tooltip config changes update

thoughtspot · Nov 19, 2024 · 0516949 · 0516949
1 parent 42dc735
commit 0516949
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 220 deletions.
diff --git a/example/custom-bar-chart/custom-chart.ts b/example/custom-bar-chart/custom-chart.ts
@@ -460,12 +460,18 @@ const renderChart = async (ctx: CustomChartContext): Promise<void> => {
             const { visualProps } = currentVisualProps;
             const elements = [
                 {
-                    key: 'color',
+                    key: 'coloraaa',
                     type: 'radio',
                     defaultValue: 'red',
                     values: ['red', 'green', 'yellow'],
                     label: 'Colors',
                 },
+                {
+                    key: 'tooltipconfig1',
+                    type: 'tooltipconfig',
+                    defaultValue: 'true',
+                    label: 'ToolTip',
+                },
                 {
                     type: 'section',
                     key: 'accordion',

diff --git a/example/custom-bar-chart/package.json b/example/custom-bar-chart/package.json
@@ -14,7 +14,7 @@
         "vite": "^4.3.5"
     },
     "dependencies": {
-        "@thoughtspot/ts-chart-sdk": "0.0.2-alpha.20",
+        "@thoughtspot/ts-chart-sdk": "link:/Users/harshmeet.singh/Desktop/ts-chart-sdk",
         "chart.js": "^4.3.0",
         "chartjs-plugin-datalabels": "^2.2.0",
         "lodash": "^4.17.21"

diff --git a/example/custom-bar-chart/pnpm-lock.yaml b/example/custom-bar-chart/pnpm-lock.yaml
diff --git a/src/types/ts-to-chart-event.types.ts b/src/types/ts-to-chart-event.types.ts
@@ -72,6 +72,8 @@ export enum TSToChartEvent {
      * @version SDK: 0.1 | ThoughtSpot:
      */
     AxisMenuActionClick = 'AxisMenuActionClick',
+
+    GetColumnData = 'GetColumnData',
 }
 
 /**

diff --git a/src/types/visual-prop.types.ts b/src/types/visual-prop.types.ts
@@ -11,6 +11,11 @@
 import type { CustomChartContext } from '../main/custom-chart-context';
 import { ColumnType } from './answer-column.types';
 import { ChartModel } from './common.types';
+
+export type TSTooltipConfig = {
+    columnIds: Array<string>;
+};
+
 /**
  * Configuration for input validation rules
  */
@@ -408,7 +413,11 @@ export interface NativeEditToolTip {
      */
     key: string;
 
-    defaultValue?: string;
+    /*
+     List of column ids that are present in ToolTipConfig by default 
+    */
+
+    defaultValue?: TSTooltipConfig;
 
     /**
      * I18n'ed string to show on the form label
-Original file line number
+Diff line change
@@ Expand Up / @@ -72,6 +72,8 @@ export enum TSToChartEvent { @@
          * @version SDK: 0.1 | ThoughtSpot:
          */
         AxisMenuActionClick = 'AxisMenuActionClick',
+        GetColumnData = 'GetColumnData',
     }
     /**
@@ Expand Down @@