SCAL-192741 added enum to support custom style config and color pallete #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 903c402 |
harshmeetTS
commented
Jul 22, 2024
src/types/common.types.ts
Outdated
| */ | ||
|
|
||
| export type CustomFontFaces = { | ||
| id?: string; |
There was a problem hiding this comment.
change to guid
abey-thomas
reviewed
Jul 22, 2024
src/types/common.types.ts
Outdated
| */ | ||
|
|
||
| export type CustomFontFaces = { | ||
| guid?: string; |
There was a problem hiding this comment.
should this be optional?
abey-thomas
reviewed
Jul 22, 2024
src/types/common.types.ts
Outdated
| }; | ||
| chartColorPalettes?: Array<{ colors: Array<string> }>; | ||
| disableColorRotation?: boolean; | ||
| chartFeatureToFontGuid: Record<CustomizableChartFeature, string>; |
There was a problem hiding this comment.
should this be optional?
abey-thomas
reviewed
Jul 22, 2024
src/types/common.types.ts
Outdated
|
|
||
| /** | ||
| * Used for Custom color pallete and Custom font for charts defined in Style customisations | ||
| * inside thoughtspot admin section |
There was a problem hiding this comment.
admin/developer section
abey-thomas
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added styleConfig type for custom style config
Changes
Why It Is Needed
Currently we are not passing app level style config for charts to ts-chart-sdk. Supported changes will be done in ts-chart-app to pass the correct values based on type specified for styleConfig
Testing