added test

thoughtspot · Jun 11, 2024 · aff0f46 · aff0f46
1 parent d8753cc
commit aff0f46
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/src/main/custom-chart-context.spec.ts b/src/main/custom-chart-context.spec.ts
@@ -112,6 +112,10 @@ describe('CustomChartContext', () => {
                 defaultChartConfig: undefined,
                 chartConfigEditorDefinition: undefined,
                 visualPropEditorDefinition: undefined,
+                allowedConfigurations: {
+                    allowColumnNumberFormatting: false,
+                    allowColumnConditionalFormatting: false,
+                },
             });
             expect(mockPostMessage).toHaveBeenCalled();
             expect(mockPostMessageToHost).not.toHaveBeenCalled();

diff --git a/src/main/custom-chart-context.ts b/src/main/custom-chart-context.ts
@@ -48,8 +48,8 @@ import * as PostMessageEventBridge from './post-message-event-bridge';
 let isInitialized = false;
 
 export type AllowedConfigurations = {
-    allowNumberFormatting: Boolean;
-    conditionalFormatting: Boolean;
+    allowColumnNumberFormatting: boolean;
+    allowColumnConditionalFormatting: boolean;
 };
 
 export type CustomChartContextProps = {
@@ -139,8 +139,8 @@ const DEFAULT_CHART_CONTEXT_PROPS: Partial<CustomChartContextProps> = {
     validateVisualProps: () => ({ isValid: true }),
     chartConfigEditorDefinition: undefined,
     allowedConfigurations: {
-        allowNumberFormatting: false,
-        conditionalFormatting: false,
+        allowColumnNumberFormatting: false,
+        allowColumnConditionalFormatting: false,
     },
 };
 

diff --git a/src/types/ts-to-chart-event.types.ts b/src/types/ts-to-chart-event.types.ts
@@ -192,8 +192,12 @@ export interface InitializeEventResponsePayload {
      * @version SDK: 0.1 | ThoughtSpot:
      */
     visualPropEditorDefinition?: VisualPropEditorDefinition;
-    // Whether user wants thoughtspot default number and conditional formatting
-    allowedConfigurations?: AllowedConfigurations,
+    /**
+     * Toggle native configurations supported by TS UI. Ex: column level number and conditional formatting.
+     *
+     * @version SDK: 0.1 | ThoughtSpot:
+     */
+    allowedConfigurations?: AllowedConfigurations;
 }
 
 /**