Merge pull request #103 from thoughtspot/add/download-async

feat async download
thoughtspot · Feb 4, 2025 · 88536aa · 88536aa
2 parents a00a6ef + c01fcc8
commit 88536aa
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "@thoughtspot/ts-chart-sdk",
     "private": false,
-    "version": "1.2.2",
+    "version": "1.2.3",
     "module": "lib/index",
     "main": "lib/index",
     "types": "lib/index",

diff --git a/src/main/custom-chart-context.ts b/src/main/custom-chart-context.ts
@@ -1038,16 +1038,16 @@ export class CustomChartContext {
          */
         this.on(
             TSToChartEvent.DownloadExcelTrigger,
-            (payload: DownloadExcelTriggerPayload) => {
+            async (payload: DownloadExcelTriggerPayload) => {
                 logger.log(
                     'DownloadExcelTrigger event triggered from TS with payload:',
                     payload,
                 );
-                return {
+                return Promise.resolve({
                     fileName: '',
                     error: '',
                     message: 'Download Excel not implemented.',
-                };
+                });
             },
         );
     };

diff --git a/src/react/use-custom-chart-context.tsx b/src/react/use-custom-chart-context.tsx
@@ -112,11 +112,11 @@ export const useChartContext = (
             payload: DownloadExcelTriggerPayload,
         ) => {
             setChartModel(context.getChartModel());
-            return {
+            return Promise.resolve({
                 fileName: '',
                 error: '',
                 message: 'Download Excel not implemented.',
-            };
+            });
         };
         // Register all external event listeners here
         getChartContextValues(context).setOnChartModelUpdate(

diff --git a/src/types/ts-to-chart-event.types.ts b/src/types/ts-to-chart-event.types.ts
@@ -110,7 +110,7 @@ export interface TSToChartEventsPayloadMap {
     ) => void;
     [TSToChartEvent.DownloadExcelTrigger]: (
         payload: DownloadExcelTriggerPayload,
-    ) => DownloadExcelTriggerResponse;
+    ) => Promise<DownloadExcelTriggerResponse>;
 }
 
 /**