SCAL-237375 rn mobile embed sdk #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekagr98
requested changes
Mar 4, 2025
Comment on lines
+1
to
+6
|
|
||
| ## Overview | ||
|
|
||
| The React Native Embed SDK is a library that allows you to embed a Thoughtspot component in your mobile application. | ||
|
|
There was a problem hiding this comment.
Can we add more details on integration and contributing.
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "name": "embed-react-native-sdk", | |||
| "version": "5.0.0", | |||
| }, | ||
| "@types/react-native": { | ||
| "optional": true | ||
| } |
There was a problem hiding this comment.
Are we using specific features from react-native-webview v11? If no then we should add it to the meta object as well.
| if (key.startsWith("on")) { | ||
| const eventName = key.substring(2); | ||
| const embedEventName = EmbedEvent[eventName as keyof typeof EmbedEvent]; | ||
| setPendingHandlers((prev) => [...prev, [embedEventName, props[key]]]); |
There was a problem hiding this comment.
Better to save them to a variable and update state once loop has ended instead of repeated state changes in loop.
| @@ -0,0 +1,29 @@ | |||
| import { WebViewProps } from 'react-native-webview'; | |||
|
|
|||
| export const VERCEL_SHELL_URL = "https://embed-vercel-shell-git-class-based-final-yinstardevs-projects.vercel.app"; | |||
There was a problem hiding this comment.
Update this to the final vercel url.
Comment on lines
+20
to
+21
| onErrorSDK?.(error); | ||
| console.error(error, errorMessage); |
There was a problem hiding this comment.
we should skip over console if onErrorSDk is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.