Convert stylesheet colors to use css vars #2755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardloveall
commented
Jan 12, 2025
| @@ -1,19 +1,19 @@ | |||
| @each $flash-type, $color in $flashes { | |||
| .flash-#{$flash-type} { | |||
| background-color: $color; | |||
| color: mix($black, $color, 60%); | |||
| color: color-mix(var(--black) 60%, $color); | |||
There was a problem hiding this comment.
These are technically the only css vars left. CSS (as far as I know) does not have any type of map equivalent. Even so, these get replaced with normal CSS vars in the end.
|
Thanks! Yeah, it's a bit big!
…have you seen a path to removing Sass entirely? That'd be fun. |
Cool, I'll work on breaking it up.
I think so. I haven't done a full audit or anything but css has come a long way. I think the blocking factor would be which old browsers does administrate need to support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting #2732
This converts all sass color variables (and a couple other variables) to use native css variables instead.
There's a lot here! If you'd prefer, I can figure out how to break this up into smaller parts; maybe one per var or something. It also doesn't get rid of all sass variables. I could go even farther and do that if we want. Just let me know.