Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #2481

Closed
wants to merge 1 commit into from
Closed

Create CODEOWNERS #2481

wants to merge 1 commit into from

Conversation

sarahraqueld
Copy link
Contributor

As part of our work to easily identify the maintainers of our open source projects, this PR adds a CODEOWNER file.

What it does:

Automatically include people as reviewers on pull requests
Provide a clear reference of who should be answering questions and making decisions
Make it easy to search for projects which need a new owner when needed
I'm adding only @nickcharlton as I've seen PRs from him lately. Let me know if it's incorrect. Thanks!

@nickcharlton
Copy link
Member

I've been kind of avoiding this, as whilst we seem to have done this elsewhere, I don't think it's actually beneficial.

Whilst I am the product manager/primary maintainer/responsible person, those with commit access don't need my "approval" to make changes, and others like @pablobm contribute so much as well, but I feel adding people to "owner" implies a level of responsibility which is unfair.

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

From the GitHub Docs, is not actually something I want and will make my notifications significantly worse — once you've been tagged to review something you're subsequently so on every notification (much like being mentioned) and it'll be really hard to distinguish those I am actively helping and those someone else is.

Of course, if we must do this because we're doing it elsewhere, then fine.

@sarahraqueld
Copy link
Contributor Author

I've been kind of avoiding this, as whilst we seem to have done this elsewhere, I don't think it's actually beneficial.

Whilst I am the product manager/primary maintainer/responsible person, those with commit access don't need my "approval" to make changes, and others like @pablobm contribute so much as well, but I feel adding people to "owner" implies a level of responsibility which is unfair.

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

From the GitHub Docs, is not actually something I want and will make my notifications significantly worse — once you've been tagged to review something you're subsequently so on every notification (much like being mentioned) and it'll be really hard to distinguish those I am actively helping and those someone else is.

Of course, if we must do this because we're doing it elsewhere, then fine.

That makes sense! I'll close this.

@sarahraqueld sarahraqueld deleted the sl-create-codeowners branch January 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants