service monitor to expose prow metrics to smaug grafana #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/M
harshad16
reviewed
Nov 12, 2021
Comment on lines
12
to
27
| relabelings: | ||
| - sourceLabels: [service] | ||
| regex: "deck" | ||
| action: replace | ||
| targetLabel: field | ||
| replacement: deck-metrics-opf-ci-prow.apps.smaug.na.operate-first.cloud | ||
| - sourceLabels: [service] | ||
| regex: "ghproxy" | ||
| action: replace | ||
| targetLabel: field | ||
| replacement: http://ghproxy-metrics-opf-ci-prow.apps.smaug.na.operate-first.cloud | ||
| - sourceLabels: [service] | ||
| regex: "hook" | ||
| action: replace | ||
| targetLabel: field | ||
| replacement: hook-metrics-opf-ci-prow.apps.smaug.na.operate-first.cloud |
There was a problem hiding this comment.
Lets remove this , i dont think it would provide any value to us.
Gregory-Pereira
force-pushed
the
expose-prow-metics-smaug
branch
from
b47313b to
040ef5f
Compare
sesheta
added
size/S
harshad16
reviewed
Nov 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Addresses issue 374. The service monitor should enable Grafana to access the metrics on its own.
Does this require new deployment ?
no
Description
Add a service monitor which scrapes the opf-ci-prow namespace and exposes those metics.