Limit memory usage based on cgroup info #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goern @harshad16 you might be interested. |
sesheta
added
the
size/S
VannTen
force-pushed
the
feat/respect_cgroup_memory_limit
branch
from
1e7afe7 to
bc32b62
Compare
codificat
reviewed
Jan 10, 2023
thoth/solver/cli.py
Outdated
| memory = limit.read() | ||
| if memory == "max": # memory.high might contain "max" -> indicates to use the memory.max value | ||
| continue | ||
| value = int(limit.read()) |
There was a problem hiding this comment.
isn't this meant to be:
Suggested change
| value = int(limit.read()) | |
| value = int(memory) |
VannTen
force-pushed
the
feat/respect_cgroup_memory_limit
branch
from
bc32b62 to
0207c59
Compare
We try to convert OOM-kill at the cgroup level into python MemoryError. The method employed has a number of caveats: - setrlimit only acts on one process, when cgroup is a group of process ; other process in the container could also consume memory - the OOM-killer might still kick in before Python raising MemoryError, depending on the particular of the Python allocator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codificat, goern The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
This should help diagnoses thoth-station/thoth-application#2690
We should get some stacktrace, which will help us locate where our python code allocates a lot. (Especially if we have a space complexity bug/problem)
This introduces a breaking change
Description
We try to convert OOM-kill at the cgroup level into python MemoryError.
The method employed has a number of caveats:
; other process in the container could also consume memory
depending on the particular of the Python allocator