Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lowercase in some show methods #1726

Merged
merged 2 commits into from
Feb 2, 2025

Apply suggestions from code review

2c1712f
Select commit
Loading
Failed to load commit list.
Merged

Use Lowercase in some show methods #1726

Apply suggestions from code review
2c1712f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 2, 2025 in 0s

76.57% (+0.03%) compared to 41aea2f

View this Pull Request on Codecov

76.57% (+0.03%) compared to 41aea2f

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.57%. Comparing base (41aea2f) to head (2c1712f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NumFieldOrd/NfOrd/NfOrd.jl 50.00% 6 Missing ⚠️
src/NumFieldOrd/NfOrd/ResidueRing.jl 0.00% 2 Missing ⚠️
src/AlgAss/AlgGrp.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   76.53%   76.57%   +0.03%     
==========================================
  Files         360      360              
  Lines      113622   113631       +9     
==========================================
+ Hits        86961    87011      +50     
+ Misses      26661    26620      -41     
Files with missing lines Coverage Δ
src/GenOrd/GenOrd.jl 82.23% <ø> (ø)
src/AlgAss/AlgGrp.jl 75.28% <75.00%> (+0.16%) ⬆️
src/NumFieldOrd/NfOrd/ResidueRing.jl 85.07% <0.00%> (+0.03%) ⬆️
src/NumFieldOrd/NfOrd/NfOrd.jl 86.08% <50.00%> (-0.28%) ⬇️

... and 29 files with indirect coverage changes