Filtering short pulses #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 20, 2014 23:28
- added function with return of CEST: getCEST() returns 1 if CEST and 0 if CET (MEZ). - added delays for filtering short PRE/POST-pulses (see DCF77.h) - changed functions for rPW and rCT to "-" for Prepulses and "+" for Postpulses i have changed the functions which reject short pulses before or after a correct pulse. It seems to correct some of that short jitter pulses better.They are detected in debug mode, but nevertheless in some cases the buffer is good to be used. -addes some function names for getWeekday() (to be implemented), getEncWeatherData() to get the encrypted MeteoTime-Data for (external) decryption, and getAlertData() to get the Civil Alert Data.
Changed getDCFTime to time_t, which compiles on both Teensy 3.1 and Arduinos now ("unsigned long" didn't for the teensy)
|
Sorry to respond so late! Thanks for all the updates. I will review and merge them as soon as I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to filter that short pulses before or after a real 100/200 mS pulse. In case of a POST-pulse i added a delay (time defined in DCF77.h as delayPost) and reinitialized the flankTime to millis() for simply ignoring that short pulse.
If a short PRE-Pulse is detected, there's a short delay (defined in DCF77.h as delayPre), the flankTime is reinitialized and the sensorvalue is re-readed. Maybe it should be possible to adapt the delayPre/delayPost-value "self-learning" by counting the errors and increasing that values automatically)
I changed the rPW and rCT to shorter "+" and "-".
As a second, i added the function getCEST, which returns 1, when CEST is active and 0 if CET is set (as always, this is meant for the next minute)
I added some function names for planned functions: getWeekday(), getEncWeatherData() and getAlertData().
getWeekday() should return the Weekday, getEncWeatherData should return the Encrypted MeteoTime-Weather-Data for external Decryption, getAlertData() should give back the German Civil Alert Data (not encrypted)
In SyncProvider.pde i changed Line 74 "unsigned long getDCFTime()" to "time_t getDCFTime()", because i got compilation errors on Teensy (3.1). Now it compiles both on Arduino Uno and Teensy 3.1