Initial proposal for hot upgrading erlang applications

lib/deployex/deployment.ex

@@ -297,7 +297,13 @@ defmodule Deployex.Deployment do
 
       from_version = Status.current_version(instance)
 
-      case Upgrade.execute(instance, from_version, release.version) do
+      case Upgrade.execute(
+             instance,
+             Storage.monitored_app_lang(),
+             Storage.monitored_app_name(),
+             from_version,
+             release.version
+           ) do
         :ok ->
           Status.set_current_version_map(instance, release,
             deployment: :hot_upgrade,

lib/deployex/release/gcp_storage.ex

@@ -39,10 +39,11 @@ defmodule Deployex.Release.GcpStorage do
   def download_and_unpack(instance, version) do
     {:ok, download_path} = Briefly.create()
 
-    monitored_app = Storage.monitored_app_name()
+    app_name = Storage.monitored_app_name()
+    app_lang = Storage.monitored_app_lang()
 
     gcp_path =
-      "https://storage.googleapis.com/#{bucket()}/dist/#{monitored_app}/#{monitored_app}-#{version}.tar.gz"
+      "https://storage.googleapis.com/#{bucket()}/dist/#{app_name}/#{app_name}-#{version}.tar.gz"
 
     :get
     |> Finch.build(gcp_path, headers(), [])
@@ -60,7 +61,14 @@ defmodule Deployex.Release.GcpStorage do
 
     {"", 0} = System.cmd("tar", ["-x", "-f", download_path, "-C", new_path])
 
-    Upgrade.check(instance, download_path, Status.current_version(instance), version)
+    Upgrade.check(
+      instance,
+      app_lang,
+      app_name,
+      download_path,
+      Status.current_version(instance),
+      version
+    )
   after
     Briefly.cleanup()
   end

lib/deployex/release/local.ex

@@ -20,9 +20,9 @@ defmodule Deployex.Release.Local do
   """
   @impl true
   def get_current_version_map do
-    monitored_app = Storage.monitored_app_name()
+    app_name = Storage.monitored_app_name()
 
-    file_path = "#{bucket()}/versions/#{monitored_app}/#{env()}/current.json"
+    file_path = "#{bucket()}/versions/#{app_name}/#{env()}/current.json"
 
     case File.read(file_path) do
       {:ok, data} ->
@@ -39,16 +39,24 @@ defmodule Deployex.Release.Local do
   """
   @impl true
   def download_and_unpack(instance, version) do
-    monitored_app = Storage.monitored_app_name()
+    app_name = Storage.monitored_app_name()
+    app_lang = Storage.monitored_app_lang()
 
-    download_path = "#{bucket()}/dist/#{monitored_app}/#{monitored_app}-#{version}.tar.gz"
+    download_path = "#{bucket()}/dist/#{app_name}/#{app_name}-#{version}.tar.gz"
 
     Status.clear_new(instance)
     new_path = Storage.new_path(instance)
 
     {"", 0} = System.cmd("tar", ["-x", "-f", download_path, "-C", new_path])
 
-    Upgrade.check(instance, download_path, Status.current_version(instance), version)
+    Upgrade.check(
+      instance,
+      app_lang,
+      app_name,
+      download_path,
+      Status.current_version(instance),
+      version
+    )
   end
 
   ### ==========================================================================

lib/deployex/release/s3.ex

@@ -38,9 +38,10 @@ defmodule Deployex.Release.S3 do
   def download_and_unpack(instance, version) do
     {:ok, download_path} = Briefly.create()
 
-    monitored_app = Storage.monitored_app_name()
+    app_name = Storage.monitored_app_name()
+    app_lang = Storage.monitored_app_lang()
 
-    s3_path = "dist/#{monitored_app}/#{monitored_app}-#{version}.tar.gz"
+    s3_path = "dist/#{app_name}/#{app_name}-#{version}.tar.gz"
 
     {:ok, :done} =
       bucket()
@@ -52,7 +53,14 @@ defmodule Deployex.Release.S3 do
 
     {"", 0} = System.cmd("tar", ["-x", "-f", download_path, "-C", new_path])
 
-    Upgrade.check(instance, download_path, Status.current_version(instance), version)
+    Upgrade.check(
+      instance,
+      app_lang,
+      app_name,
+      download_path,
+      Status.current_version(instance),
+      version
+    )
   after
     Briefly.cleanup()
   end

lib/deployex/upgrade.ex

@@ -26,20 +26,33 @@ defmodule Deployex.Upgrade do
   This function check the release package type
   """
   @impl true
-  @spec check(integer(), binary(), binary() | charlist() | nil, binary() | charlist()) ::
+  @spec check(
+          integer(),
+          String.t(),
+          String.t(),
+          binary(),
+          binary() | charlist() | nil,
+          binary() | charlist()
+        ) ::
           {:ok, :full_deployment | :hot_upgrade} | {:error, any()}
-  def check(instance, download_path, from_version, to_version) do
-    default().check(instance, download_path, from_version, to_version)
+  def check(instance, app_lang, app_name, download_path, from_version, to_version) do
+    default().check(instance, app_lang, app_name, download_path, from_version, to_version)
   end
 
   @doc """
   This function triggers the hot code reloading process
   """
   @impl true
-  @spec execute(integer(), binary() | charlist() | nil, binary() | charlist() | nil) ::
+  @spec execute(
+          integer(),
+          String.t(),
+          String.t(),
+          binary() | charlist() | nil,
+          binary() | charlist() | nil
+        ) ::
           :ok | {:error, any()}
-  def execute(instance, from_version, to_version) do
-    default().execute(instance, from_version, to_version)
+  def execute(instance, app_lang, app_name, from_version, to_version) do
+    default().execute(instance, app_lang, app_name, from_version, to_version)
   end
 
   ### ==========================================================================

lib/deployex/upgrade/adapter.ex

@@ -4,8 +4,21 @@ defmodule Deployex.Upgrade.Adapter do
   """
 
   @callback connect(integer()) :: {:error, :not_connecting} | {:ok, atom()}
-  @callback check(integer(), binary(), binary() | charlist() | nil, binary() | charlist()) ::
+  @callback check(
+              integer(),
+              String.t(),
+              String.t(),
+              binary(),
+              binary() | charlist() | nil,
+              binary() | charlist()
+            ) ::
               {:ok, :full_deployment | :hot_upgrade} | {:error, any()}
-  @callback execute(integer(), binary() | charlist() | nil, binary() | charlist() | nil) ::
+  @callback execute(
+              integer(),
+              String.t(),
+              String.t(),
+              binary() | charlist() | nil,
+              binary() | charlist() | nil
+            ) ::
               :ok | {:error, any()}
 end