feat: check references to rules and articles #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
ReferenceCheck
visitor:regulations:guideline:...
,guidelines:regulation:...
orREgulations:...:...
).An example output with errors:
Note:
Given that we want to check cross-references between regulations and guidelines (who live in different ASTs), we need to keep the state of the
ReferenceCheck
class after eachWCADocument
has been visited. The obvious way to do this is to use a Singleton. I think it makes sense to do it this way, in order to minimize the changes required to theWCAParser
class. Moreover, there's additional logic that needs to run when the parser gets an instance of theReferenceCheck
visitor class (see theReferenceCheck.get_instance
method).