Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-sof-logger: disable again dma_nudge() workaround for stuck DMA #4333 #880

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

check-sof-logger: disable again dma_nudge() workaround for stuck DMA #4333 #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test-case/check-sof-logger.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,12 @@ main()

# Workaround for DMA trace bug
# https://github.com/thesofproject/sof/issues/4333
if [ "$f" = data ]; then
# if [ "$f" = data ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment intentionally left in? Also not sure I follow the reasoning for the if false; then line. Guessing that's what the comments are referencing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a test DRAFT, don't take it seriously.

The if false is a way to comment out 10 lines with a one-line change.


# let's check whether #4333 was finally fixed by sof #4763
# + linux #3523
if false; then

dloge "Empty or stuck DMA trace? Let's try to nudge it."
dloge ' vv Workaround for SOF issue 4333 vv'
local second_chance="$LOG_ROOT/logger.dma_trace_bug_4333.txt"
Expand Down