Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: Intel: sof_sdw: Add quirking for Asus Zenbooks with SSID 0x10431e13 #5301

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

rfvirgil
Copy link

These two patches add a quirk for Asus Zenbooks with PCI Subsystem ID 0x10431e13.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but has a merge commit as patch 3.
@bardliao @ujfalusi pls review.

@bardliao
Copy link
Collaborator

Yeah, we don't need the merge commit.

Add lookup of PCI subsystem vendor:device ID to find a quirk.

The subsystem ID (SSID) is part of the PCI specification to uniquely
identify a particular system-specific implementation of a hardware
device.

Unlike DMI information, it identifies the sound hardware itself, rather
than a specific model of PC. SSID can be more reliable and stable than
DMI strings, and is preferred by some vendors as the way to identify
the actual sound hardware.

Signed-off-by: Richard Fitzgerald <[email protected]>
Asus laptops with sound PCI subsystem ID 1043:1e13 have the DMICs
connected to the host instead of the CS42L43 so need the
SOC_SDW_CODEC_MIC quirk.

Signed-off-by: Richard Fitzgerald <[email protected]>
@rfvirgil rfvirgil force-pushed the topic/asus-UX5406SA branch from b5d6c13 to f026364 Compare January 21, 2025 10:04
@rfvirgil
Copy link
Author

I've re-pushed without the merge commit.
(GitHub UI didn't do what I expected, amazingly it's more difficult to use than plain command-line git)

@bardliao bardliao merged commit 0c2bf75 into thesofproject:topic/sof-dev Jan 21, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants