ASoC: Intel: sof_sdw: Add support for Fatcat board in PTL platform #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an entry in the soundwire quirk table for Fatcat boards in PTL RVP Signed-off-by: Uday M Bhat <[email protected]> Signed-off-by: Jairaj Arava <[email protected]>
jairaj-arava
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
|
@jairaj-arava there's another PR for this #5258 . Can you please sync with @macchian |
|
The quirk adds PCH DMIC support and nothing else. Am I correct? |
|
macchian
reviewed
Dec 4, 2024
| { | ||
| .callback = sof_sdw_quirk_cb, | ||
| .matches = { | ||
| DMI_MATCH(DMI_SYS_VENDOR, "Google"), |
There was a problem hiding this comment.
Are we still remaining the SYS_VENDOR string in coreboot? Perhaps DMI_PRODUCT_FAMILY or DMI_MANUFACTURER instead?
There was a problem hiding this comment.
I hope manufacturer string in coreboot is used for SYS_VENDOR. We can use DMI_PRODUCT_FAMILY too, however, we are sticking to the way we defined in MTL platform for REX boards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry in the soundwire quirk table for Fatcat boards in PTL RVP