ASOC: SOF: Intel: hda-loader: add debug to IOC timeout #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a single-shot DMA is complete, hda_dsp_stream_get_position() will point to hstream->bufsize. Current code zeros out the returned position in this case as ALSA core does not expect to get such values in its pointer callback. While valid in the ALSA case, this is no helpful when debugging other DMA usages, e.g. firmware loading. Allow valid value of hstream->bufsize to be returned as a position. Signed-off-by: Kai Vehmanen <[email protected]>
Print out DMA position upon failure to get IOC notification. Signed-off-by: Kai Vehmanen <[email protected]>
|
Uses debugging approach proposed in #5141 (but applies to the IOC error case). |
ujfalusi
reviewed
Aug 8, 2024
| @@ -1082,7 +1082,7 @@ snd_pcm_uframes_t hda_dsp_stream_get_position(struct hdac_stream *hstream, | |||
| break; | |||
| } | |||
|
|
|||
| if (pos >= hstream->bufsize) | |||
| if (pos > hstream->bufsize) | |||
There was a problem hiding this comment.
you could make this conditional and apply it to non cyclic (one shot) transfers only, like the fw loading, library loading.
| dev_err(sdev->dev, "Code loader DMA did not complete\n"); | ||
| struct hdac_stream *hstream = &hext_stream->hstream; | ||
| snd_pcm_uframes_t pos = hda_dsp_stream_get_position(hstream, SNDRV_PCM_STREAM_PLAYBACK, 0); | ||
| dev_err(sdev->dev, "Code loader DMA did not complete, DMA pos %lu/%u\n", |
There was a problem hiding this comment.
Empty line between variable declaration and code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug patch to help test out the case #5136 is addressing.