ASoC: SOF: Intel: hda: improve code loader and prepare for SoundWire BPT reuse #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
reviewed
Nov 10, 2023
The existing code conflates capture stream and ICCMAX stream. This isn't going to be true any longer when we add support for SDW BPT RX streams. Add a boolean tag to flag ICCMAX streams. No functionality change, only future-proofing change. Signed-off-by: Pierre-Louis Bossart <[email protected]>
We need to reuse cl_prepare, cl_trigger and cl_cleanup helpers from a SoundWire context where only the device information is available. Rather than pass the 'sdev' argument, use get_drvdata() to retrieve the required structure. For consistency, rename hda_cl_stream_prepare() as hda_cl_prepare(). These three helpers are also exported so that they can be referenced from another module. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
hda/cl-sdw-bpt-dma-changes
branch
from
6cf851d to
a06109e
Compare
RanderWang
previously approved these changes
Nov 13, 2023
ujfalusi
previously approved these changes
Nov 13, 2023
lyakh
reviewed
Nov 13, 2023
The HDaudio stream interrupts are ignored unless the stream is PCM or compressed audio. For alternate non-audio usages, such as code loader or SoundWire BPT case, the IOC interrupt on the last buffer transferred is silently ignored. This patch adds a 'struct completion' for each HDaudio stream. This capability helps detect if the non-audio data transfers completed. There is no performance impact for audio streams. In the code loader case, the code currently starts the DMA and directly checks if the firmware status changes, without checking if the DMA succeeded. With a first pass waiting for the DMA to complete, system validation engineers can gather more precise timing information on firmware boot time or root-cause boot failures more accurately. A timeout of 500ms was selected for the code loader DMA. This is an experimental value which should be more than enough - higher values would certainly be problematic from a usage/latency perspective. Signed-off-by: Pierre-Louis Bossart <[email protected]>
The Yoda grammar and multiple negatives are unclear. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
hda/cl-sdw-bpt-dma-changes
branch
from
a06109e to
1b67be7
Compare
ujfalusi
approved these changes
Nov 13, 2023
RanderWang
approved these changes
Nov 14, 2023
ranj063
approved these changes
Nov 14, 2023
| continue; | ||
| if (!s->substream && !s->cstream) { | ||
| /* | ||
| * when no substream is found, the DMA may used for code loading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial patches are harmless but the last patch is quite invasive with the addition of a DMA completion timeout for the code loader.
These patches prepare the integration of the SoundWire BPT support which will rely on parts of the code loader examples.
One additional benefit is that a simple 'dmesg | grep "Code loader"' will tell us how much time is spent transferring the firmware v. waiting for the firmware to boot.
@ranj063 @ujfalusi @bardliao @RanderWang @kv2019i comments welcome.