Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: Sidebar component removal #913

Merged
merged 6 commits into from
Dec 9, 2024
Merged

dApp: Sidebar component removal #913

merged 6 commits into from
Dec 9, 2024

Conversation

kpyszkowski
Copy link
Contributor

@kpyszkowski kpyszkowski commented Dec 3, 2024

Closes: AENG-142

Changes

  • Removed Sidebar component
  • Removed SidebarContext
  • Removed useSidebar hook
  • Removed Sidebar theme definition

Copy link

linear bot commented Dec 3, 2024

@kpyszkowski kpyszkowski marked this pull request as draft December 3, 2024 16:45
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 6743da7
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/6752e970acc48800084a9550
😎 Deploy Preview https://deploy-preview-913--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 6743da7
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/6752e9701727c000089ee066
😎 Deploy Preview https://deploy-preview-913--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kpyszkowski kpyszkowski marked this pull request as ready for review December 5, 2024 14:01
@kpyszkowski kpyszkowski requested review from kkosiorowska and r-czajkowski and removed request for kkosiorowska December 5, 2024 14:01
useMultiStyleConfig,
Image,
} from "@chakra-ui/react"
import { useScrollbarVisibility, useSidebar } from "#/hooks"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the useScrollbarVisibility hook. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref commit: 9a506e5

@kkosiorowska kkosiorowska merged commit 83b81ed into main Dec 9, 2024
28 checks passed
@kkosiorowska kkosiorowska deleted the sidebar-removal branch December 9, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants