Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert component for wallet connection #901

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented Nov 27, 2024

Closes AENG-25
Closes #571
Closes #872

This PR updates the logic for displaying alerts for a wallet connection. What has been changed:

  • Allowed to pass status to ConnectWalletAlert.
  • Changed description type to ReactNode to create more custom content.
  • Instead of passing title and description to the component, we just pass the type. This keeps the alert logic in one place, but also makes it easier to simply pass just one prop.
  • Updated content for connection alerts.

@kkosiorowska kkosiorowska self-assigned this Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 6558b62
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/674ed78fb4efca00087b84bd
😎 Deploy Preview https://deploy-preview-901--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 6558b62
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/674ed78fd667a90008946aa7
😎 Deploy Preview https://deploy-preview-901--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linear bot commented Nov 27, 2024

@kkosiorowska kkosiorowska requested a review from nkuba November 28, 2024 08:02
Copy link
Contributor

@kpyszkowski kpyszkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving approval for @r-czajkowski

@r-czajkowski r-czajkowski merged commit 1bfe0fc into main Dec 3, 2024
28 checks passed
@r-czajkowski r-czajkowski deleted the connection-alert branch December 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants