Update Sepolia contracts deployments artifacts #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We redeployed the latest version of contracts to sepolia.
We don't need to duplicate the contracts artifacts by copying them to SDK module, we can import them from the contracts module.
We don't need to import the types for contracts initialization as we can simplify them by removing the deployedAtBlockNumber property which is not used in our SDK code.
✅ Deploy Preview for acre-dapp-testnet canceled.
|
We want to avoid ignoring the prefer-dfefault-export rule, so we define a dedicated file to DepositState.
| * from the contract deployment artifact. It can be overwritten by setting a | ||
| * {@link EthersContractConfig.deployedAtBlockNumber} property. | ||
| */ | ||
| protected readonly deployedAtBlockNumber: number |
There was a problem hiding this comment.
Why did we remove it? This is useful for fetching events.
There was a problem hiding this comment.
The artifacts the deployment script produces with the upgradable deployments plugin don't contain the block number as per keep-network/hardhat-helpers@232b917.
Since we're not fetching the events in the dApp currently, I thought that for simplicity we could remove the deployedAtBlockNumber property, and resolve it later if we really need it.
1 task
Co-authored-by: Rafał Czajkowski <[email protected]>
r-czajkowski
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We redeployed the latest contracts version to Sepolia. Here we update the artifacts.